From 5da9ab2f43c0ef1963736abf7dbfed9ff2194d76 Mon Sep 17 00:00:00 2001 From: Gary Snider <75227981+gsnider2195@users.noreply.github.com> Date: Fri, 18 Oct 2024 13:36:55 -0700 Subject: [PATCH 1/2] Fixed `invoke tests` exiting early even when tests pass. --- changes/TBD.fixed | 1 + tasks.py | 6 ++++-- 2 files changed, 5 insertions(+), 2 deletions(-) create mode 100644 changes/TBD.fixed diff --git a/changes/TBD.fixed b/changes/TBD.fixed new file mode 100644 index 0000000..79e7e8f --- /dev/null +++ b/changes/TBD.fixed @@ -0,0 +1 @@ +Fixed `invoke tests` exiting early even when tests pass. diff --git a/tasks.py b/tasks.py index cceed6d..c4b4b24 100644 --- a/tasks.py +++ b/tasks.py @@ -731,7 +731,8 @@ def pylint(context): else: print("No migrations directory found, skipping migrations checks.") - raise Exit(code=exit_code) + if exit_code != 0: + raise Exit(code=exit_code) @task(aliases=("a",)) @@ -775,7 +776,8 @@ def ruff(context, action=None, target=None, fix=False, output_format="concise"): if not run_command(context, command, warn=True): exit_code = 1 - raise Exit(code=exit_code) + if exit_code != 0: + raise Exit(code=exit_code) @task From b20cb37b7bd3526ed48bd0c7585d0544e71bcd6b Mon Sep 17 00:00:00 2001 From: Gary Snider <75227981+gsnider2195@users.noreply.github.com> Date: Fri, 18 Oct 2024 13:38:28 -0700 Subject: [PATCH 2/2] changelog --- changes/{TBD.fixed => 54.fixed} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename changes/{TBD.fixed => 54.fixed} (100%) diff --git a/changes/TBD.fixed b/changes/54.fixed similarity index 100% rename from changes/TBD.fixed rename to changes/54.fixed