Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next Breaking Change Candidates #210

Open
natsuk4ze opened this issue Feb 7, 2024 · 0 comments
Open

Next Breaking Change Candidates #210

natsuk4ze opened this issue Feb 7, 2024 · 0 comments
Labels
✋ pending Pending for some reasons

Comments

@natsuk4ze
Copy link
Owner

natsuk4ze commented Feb 7, 2024

1. Upgrade min iOS version to 12

With the Xcode update, Flutter's minimum IOS support version has been upgraded to 12. This plugin should follow suit.

2. Upgrade min Android sdk version to 21

The min sdk version supported by this plugin is 21. However, the actual build.gradle is listed at 19.

minSdk 19

This is a result of putting off the breaking change. Currently, this plugin can be compiled with Android sdk 19. However, there is no guarantee that all features will work properly under sdk version 21, and we do not intend to support these in the future.
For more clarity, we should upgrade the minSdk in build.gradle to 21.

3. Rename hasAccess and requestAccess

The names hasPermission and requestPermission may be easier to understand.

4. Update GalException.fromCode to GalException.fromPlatformException

@natsuk4ze natsuk4ze added 👀 in triage This issue or pull request is in triage ✋ pending Pending for some reasons labels Feb 7, 2024
@natsuk4ze natsuk4ze removed the 👀 in triage This issue or pull request is in triage label Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✋ pending Pending for some reasons
Projects
None yet
Development

No branches or pull requests

1 participant