You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have half a mind to rewrite our Args class. When I wrote that, I didn't have good information from the parser, and I thought the only way to consume the arguments properly was to build a sort of state machine.
I think using this information (vs what we do now, which is to basically smoosh them together) will greatly simplify that class and allow us to consume the arguments in order, thus fixing this bug. 🤞
The text was updated successfully, but these errors were encountered:
Because of the way we build our argument instructions, the following code produces a compilation error:
https://github.com/rack/rack/blob/main/lib/rack/multipart/uploaded_file.rb#L16-L17
Basically, you cannot have this:
I have half a mind to rewrite our Args class. When I wrote that, I didn't have good information from the parser, and I thought the only way to consume the arguments properly was to build a sort of state machine.
Now Prism gives us much better information, i.e.:
I think using this information (vs what we do now, which is to basically smoosh them together) will greatly simplify that class and allow us to consume the arguments in order, thus fixing this bug. 🤞
The text was updated successfully, but these errors were encountered: