From 55063a004500fb10b2d514ece15da8e63994c221 Mon Sep 17 00:00:00 2001 From: Scott Bell Date: Mon, 28 Oct 2024 09:24:23 +0100 Subject: [PATCH] removing debug statements for PR review --- .../functional/plugins/comps/comps.e2e.spec.js | 1 + src/plugins/comps/CompsManager.js | 16 ---------------- src/plugins/comps/CompsTelemetryProvider.js | 9 --------- 3 files changed, 1 insertion(+), 25 deletions(-) diff --git a/e2e/tests/functional/plugins/comps/comps.e2e.spec.js b/e2e/tests/functional/plugins/comps/comps.e2e.spec.js index dae5c225d48..72ce7d86e90 100644 --- a/e2e/tests/functional/plugins/comps/comps.e2e.spec.js +++ b/e2e/tests/functional/plugins/comps/comps.e2e.spec.js @@ -27,6 +27,7 @@ import { import { expect, test } from '../../../../pluginFixtures.js'; test.describe('Comps', () => { + test.use({ failOnConsoleError: false }); test.beforeEach(async ({ page }) => { // Open a browser, navigate to the main page, and wait until all networkevents to resolve await page.goto('./', { waitUntil: 'domcontentloaded' }); diff --git a/src/plugins/comps/CompsManager.js b/src/plugins/comps/CompsManager.js index 50b0d0f354a..0fc06516194 100644 --- a/src/plugins/comps/CompsManager.js +++ b/src/plugins/comps/CompsManager.js @@ -115,10 +115,6 @@ export default class CompsManager extends EventEmitter { const loadVersion = ++this.#loadVersion; if (!_.isEqual(this.#telemetryOptions, telemetryOptions)) { - console.debug( - `😩 Reloading comps manager ${this.#domainObject.name} due to telemetry options change.`, - telemetryOptions - ); this.#destroy(); } @@ -131,9 +127,6 @@ export default class CompsManager extends EventEmitter { await this.#loadComposition(); // Check if a newer load has been initiated if (loadVersion !== this.#loadVersion) { - console.debug( - `🔄 Reloading comps manager in composition wait ${this.#domainObject.name} due to newer load.` - ); await this.#currentLoadPromise; return; } @@ -145,16 +138,9 @@ export default class CompsManager extends EventEmitter { await this.#startListeningToUnderlyingTelemetry(); // Check again for newer load if (loadVersion !== this.#loadVersion) { - console.debug( - `🔄 Reloading comps manager in telemetry wait ${this.#domainObject.name} due to newer load.` - ); await this.#currentLoadPromise; return; } - console.debug( - `✅ Comps manager ${this.#domainObject.name} is ready.`, - this.#telemetryCollections - ); this.#loaded = true; } })(); @@ -259,8 +245,6 @@ export default class CompsManager extends EventEmitter { const imputedDatum = this.#getImputedDataUsingLOCF(fakeData, telemetryCollection); if (imputedDatum) { alignedValues.push(imputedDatum); - } else { - console.debug(`🚨 Missing data for ${keyString} at ${timestamp}`); } }); diff --git a/src/plugins/comps/CompsTelemetryProvider.js b/src/plugins/comps/CompsTelemetryProvider.js index 4c4f710b853..c53676d80d5 100644 --- a/src/plugins/comps/CompsTelemetryProvider.js +++ b/src/plugins/comps/CompsTelemetryProvider.js @@ -80,11 +80,6 @@ export default class CompsTelemetryProvider { parameters, callbackID }; - console.debug( - `📝 Requesting calculation for ${domainObject.name} with callback ID ${callbackID}:`, - options, - payload - ); this.#sharedWorker.port.postMessage(payload); }); }); @@ -130,9 +125,6 @@ export default class CompsTelemetryProvider { size: 1 }; specificCompsManager.load(telemetryOptions); - console.debug( - `📝 Starting subscription for ${domainObject.name} with callback ID ${callbackID}` - ); return () => { delete this.#subscriptionCallbacks[callbackID]; specificCompsManager.stopListeningToUnderlyingTelemetry(); @@ -171,7 +163,6 @@ export default class CompsTelemetryProvider { console.error('📝 Error calculating request:', event.data); this.#requestPromises[callbackID].resolve([]); } else { - console.debug(`🧮 Calculation request result for ${callbackID}:`, result); this.#requestPromises[callbackID].resolve(result); } delete this.#requestPromises[callbackID];