Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor some code to be readable #13

Open
hschilling opened this issue Oct 9, 2021 · 0 comments
Open

Refactor some code to be readable #13

hschilling opened this issue Oct 9, 2021 · 0 comments
Labels
refactor Code mods for better maintainability

Comments

@hschilling
Copy link
Contributor

Some code is using short-circuit boolean expressions that make it difficult to interpret the code.

As an example

mag_paper = (mag_index >= 0 and mag_res[mag_index]) or {}

would be better written as

mag_paper = {}
if mag_index >= 0:
    mag_paper = mag_res.get(mag_index, {})
@hschilling hschilling added the refactor Code mods for better maintainability label Oct 9, 2021
@dsmith111 dsmith111 assigned dsmith111 and unassigned dsmith111 Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Code mods for better maintainability
Projects
None yet
Development

No branches or pull requests

2 participants