Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECDSA, phpseclib and PHP7: what is the current status? #118

Open
matrey opened this issue Jun 12, 2017 · 4 comments
Open

ECDSA, phpseclib and PHP7: what is the current status? #118

matrey opened this issue Jun 12, 2017 · 4 comments

Comments

@matrey
Copy link

matrey commented Jun 12, 2017

Hi

I tried using ES512 but got the following error:

Fatal error: Uncaught InvalidArgumentException: phpseclib 1.0.0(LTS), even the latest 2.0.0, doesn't support PHP7 yet in /.../vendor/namshi/jose/src/Namshi/JOSE/Signer/OpenSSL/ECDSA.php:15

But phpseclib seems to be alright these days with PHP 7 (their builds pass on PHP 7 and 7.1, see https://travis-ci.org/phpseclib/phpseclib)

If I comment out the 2 version check blocks in Signer/OpenSSL/ECDSA.php then it seems to be working OK.

Is the block for PHP 7 still justified? If yes, could it at least be made more explicit in the README of this project? Also, would it be possible to emphasize the need to require phpseclib for ECSDA support in the same README?

Thanks

@travisfisher
Copy link

I'm having the same issue on PHP 7 and agree with @matrey that it seems to make sense to remove this block.

@GrahamCampbell
Copy link
Contributor

GrahamCampbell commented Jul 20, 2017

I use phpseclib 2.0 on PHP 7.1 without issues.

@darrynten
Copy link

darrynten commented Sep 6, 2019

This is still an issue for me

  • ES512
  • phpseclib 2.0.21
  • jose 7.2.3

@Spomky
Copy link
Contributor

Spomky commented Sep 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants