Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] More time options in auto-lock. #5

Open
GuiSousa135 opened this issue Dec 7, 2024 · 8 comments · Fixed by #6
Open

[Feature request] More time options in auto-lock. #5

GuiSousa135 opened this issue Dec 7, 2024 · 8 comments · Fixed by #6
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@GuiSousa135
Copy link

Describe what you'd like to see added to the app

It would be very helpful to have more options for different times in the auto-lock settings.

Additional information

Examples: 1 minute, 5 minutes, 10 minutes, 30 minutes, 1 hour, 2 hours

@GuiSousa135 GuiSousa135 added the enhancement New feature or request label Dec 7, 2024
@nain-F49FF806 nain-F49FF806 added the good first issue Good for newcomers label Dec 7, 2024
nain-F49FF806 added a commit that referenced this issue Dec 7, 2024
@nain-F49FF806 nain-F49FF806 reopened this Dec 7, 2024
@nain-F49FF806
Copy link
Owner

nain-F49FF806 commented Dec 7, 2024

PR #6 adds option to set your own delay duration (in minutes).
This way you get all the options mentioned above and more, by just entering the duration value in minutes.
Example (1,5,10,30,60,120)

@GuiSousa135 You could try the attached apk and see if it works as intended.

aer-app-release.zip

@ghost
Copy link

ghost commented Dec 7, 2024

PR #6 adds option to set your own delay duration (in minutes).
This way you get all the options mentioned above and more, by just entering the duration value in minutes.
Example (1,5,10,30,60,120)

@GuiSousa135 You could try the attached apk and see if it works as intended.

aer-app-release.zip

I've set the duration to 25 mins but it didn't auto-lock for me

@nain-F49FF806
Copy link
Owner

nain-F49FF806 commented Dec 7, 2024

@rywz Thanks for the report. Can you confirm that

  • "Automatically lock access after delay" switch is on? By default it is off.
  • That the config screen is closed. Otherwise it may not have yet activated the autolock job.

I tried this with the same duration and just got a toast notification that it did indeed lock.

@ghost
Copy link

ghost commented Dec 8, 2024

@rywz Thanks for the report. Can you confirm that

  • "Automatically lock access after delay" switch is on? By default it is off.

Yes.

  • That the config screen is closed. Otherwise it may not have yet activated the autolock job.

I've tried it again, same result

I tried this with the same duration and just got a toast notification that it did indeed lock.

It could be a Xiaomi issue, what's your device?

@nain-F49FF806
Copy link
Owner

nain-F49FF806 commented Dec 8, 2024

@rywz Thanks for the report. Can you confirm that

  • "Automatically lock access after delay" switch is on? By default it is off.

Yes.

  • That the config screen is closed. Otherwise it may not have yet activated the autolock job.

I've tried it again, same result

I tried this with the same duration and just got a toast notification that it did indeed lock.

It could be a Xiaomi issue, what's your device?

That maybe the case. I have tested on a Samsung.
I suppose we must first see if auto lock even works normally on the Xiaomi device in question.
You could try first using Anemo, or the latest Aer release which still has the fixed 15 min timer.

If that also doesn't work, then this PR may not be the culprit, and we can open a bug tracking issue for Xiaomi devices.

@nain-F49FF806
Copy link
Owner

Perhaps related 2bllw8/anemo#55

@ghost
Copy link

ghost commented Dec 9, 2024

@rywz Thanks for the report. Can you confirm that

  • "Automatically lock access after delay" switch is on? By default it is off.

Yes.

  • That the config screen is closed. Otherwise it may not have yet activated the autolock job.

I've tried it again, same result

I tried this with the same duration and just got a toast notification that it did indeed lock.

It could be a Xiaomi issue, what's your device?

That maybe the case. I have tested on a Samsung.
I suppose we must first see if auto lock even works normally on the Xiaomi device in question.
You could try first using Anemo, or the latest Aer release which still has the fixed 15 min timer.

If that also doesn't work, then this PR may not be the culprit, and we can open a bug tracking issue for Xiaomi devices.

Auto-lock doesn't usually work as intended on Xiaomi devices. For example, it works perfectly for Signal, but not for Bitwarden.. and I don't know what's needed to make it work, another ximi classic 🦅

@nain-F49FF806
Copy link
Owner

For example, it works perfectly for Signal, but not for Bitwarden.. and I don't know what's needed to make it work, another ximi classic 🦅

This is useful information...
As both are open source, it should be possible to look at how they are implementing it differently.

But this seems separate from the current issue (above feature request). And we can track this bug separately.

@nain-F49FF806 nain-F49FF806 moved this to Wishlist in Aer development Dec 10, 2024
@nain-F49FF806 nain-F49FF806 moved this from Wishlist to Review in Aer development Dec 10, 2024
@nain-F49FF806 nain-F49FF806 moved this from Review to Up next in Aer development Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: Up next
Development

Successfully merging a pull request may close this issue.

2 participants