Skip to content
This repository has been archived by the owner on Nov 10, 2017. It is now read-only.

update to react v0.14 #29

Open
lionelB opened this issue Nov 11, 2014 · 8 comments
Open

update to react v0.14 #29

lionelB opened this issue Nov 11, 2014 · 8 comments

Comments

@lionelB
Copy link
Contributor

lionelB commented Nov 11, 2014

since the API is/has changed, should we update to use last react versions ?

@lionelB
Copy link
Contributor Author

lionelB commented Sep 1, 2015

should be 0.14

@n1k0 n1k0 changed the title update to react v0.12 update to react v0.14 Sep 1, 2015
@n1k0
Copy link
Owner

n1k0 commented Sep 1, 2015

Sure. Could you take care of this?

@lionelB
Copy link
Contributor Author

lionelB commented Sep 1, 2015

yup !

@lionelB
Copy link
Contributor Author

lionelB commented Sep 4, 2015

I've started with my old PR (#30) but I'm stucked with test :(
trying to updgrade jest and since it relies on jsdom also need io.js
Sooooo I was thinking, perhap's, we can use karma ? (don't hit me)

@n1k0
Copy link
Owner

n1k0 commented Sep 4, 2015

Nodejs 4.0 being about to be released, we can just wait so jsdom will be available. Also, I'd like to throw jest out of the window as soon as possible, before writing other tests. I'd like the project to move using mocha, chai and sinon. I know this is a big change, but much likely to be maintainable on the long term. I didn't like jest much, to say the least.

@lionelB
Copy link
Contributor Author

lionelB commented Sep 4, 2015

will try to find a version of jest that work so I can finish v0.14
refactoring and after that .... bye bye jest

2015-09-04 10:44 GMT+02:00 Nicolas Perriault [email protected]:

Nodejs 4.0 being about to be released, we can just wait so jsdom will be
available. Also, I'd like to throw jest out of the window as soon as
possible, before writing other tests. I'd like the project to move using
mocha, chai and sinon. I know this is a big change, but much likely to be
maintainable on the long term. I didn't like jest much, to say the least.


Reply to this email directly or view it on GitHub
#29 (comment).

@lionelB
Copy link
Contributor Author

lionelB commented Sep 9, 2015

ok I will also remove jest
rrr

@n1k0
Copy link
Owner

n1k0 commented Sep 9, 2015

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants