Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apiServerURL is unable to updated from environment. #72

Open
joyhope opened this issue Dec 3, 2023 · 1 comment
Open

apiServerURL is unable to updated from environment. #72

joyhope opened this issue Dec 3, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@joyhope
Copy link
Contributor

joyhope commented Dec 3, 2023

The code const is wrong.
var url = const String.fromEnvironment( 'API_SERVER_URL', defaultValue: defaultAPIServerURL, );

With the const, the URL is always defaultAPISserverURL, the const should be removed if want to support ENV parameter setup.

@joyhope
Copy link
Contributor Author

joyhope commented Dec 3, 2023

otherwise, the current only supports compile-time define, with --dart-define.

If supports the environment setup, it is easy to use the released version. It is easy for user to switch for the different background servers.

@mylxsw mylxsw added the bug Something isn't working label Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants