New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"No lyrics found" #22

Open

NathanBnm opened this issue Jan 29, 2019 · 1 comment

Contributor

NathanBnm commented Jan 29, 2019

I think that fixing #19 was too strict. Because some songs have no lyrics displayed. But lyrics were here before, and they are on Letras. Maybe you have to review how you actually check the lyrics match with Letras.

I had this issue with the song "Heroes" from "Måns Zelmerlöw" (maybe due to the accents? Idk).

muriloventuroso added a commit that referenced this issue


          New check for correctly lyrics. #22

07fafbb

Owner

muriloventuroso commented Jan 30, 2019

I tested this song and now the lyrics are being displayed correctly. I'll leave the issue open if the problem happens again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment