Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secrets has the AwsVersionId Key by default #42

Open
james-nduka opened this issue Jan 25, 2021 · 2 comments
Open

Secrets has the AwsVersionId Key by default #42

james-nduka opened this issue Jan 25, 2021 · 2 comments

Comments

@james-nduka
Copy link

Can we avoid each secret being created to include the key for AWSVersionID?

We have a CRD that can only accept a single Key/Value and it is currently not compatible with AWSSecret CRD's

@mumoshu
Copy link
Owner

mumoshu commented Jan 25, 2021

@james-nduka Hey! It's not supported, but technically possible. Today, we only use AWSVersionID for change detection:

https://github.com/mumoshu/aws-secret-operator/search?q=AWSVersionID

We may instead use another store, like some annotation on the secret resource for the same purpose, which would help your use-case.

Probably it should be configurable via some AwsSecret field?

@ChangSurrey
Copy link

I agree that if it's only for change detection purpose, using an annotation makes more sense than including the version ID as part of the AWSSecret CRD itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants