Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admin2: refactor performance settings #436

Open
jlillis opened this issue Jul 4, 2023 · 2 comments
Open

admin2: refactor performance settings #436

jlillis opened this issue Jul 4, 2023 · 2 comments

Comments

@jlillis
Copy link
Contributor

jlillis commented Jul 4, 2023

Which resource(s) have this problem?
admin2

Describe the bug
admin2 has performance settings which allow the user to select a performance priority (CPU, RAM, or "auto") which will allow them to unload unused UIs. While the settings exist, they are not actually used by anything.

Expected behavior
admin2 should allow for cpu/memory prioritization by allowing users to unload unused UIs.

Screenshots
image

Additional context
Most (but not all) of the individual UI scripts are already partially setup with this setting in mind - their aWidget.Show() method will check if the form exists or not and their aWidget.Close(destroy) method has accepts an argument to indicate whether the UI should actually be destroyed or just hidden.

Additionally, I think we can simplify things by remove the "advanced" performance options and just have the CPU/RAM/auto options.

@Dark-Dragon
Copy link
Contributor

The 'speed' option would keep everything loaded, whereas the 'memory' option would destroy all the widgets after use, but what would the 'auto' setting do? Keep widgets for a certain duration? Analyze which widgets are used the most and destroy the others? From the implementation side it might be easier to have the 3rd option be 'custom' and then prompt the user to select which widgets to keep loaded (via the existing 'advanced' window)

@jlillis
Copy link
Contributor Author

jlillis commented Aug 14, 2023

It seems there is no actual logic for the "auto" setting as of now. My preference would be just to remove it and have just the "memory" and "cpu" options.

@jlillis jlillis added this to admin2 Jul 11, 2024
@jlillis jlillis moved this to To do in admin2 Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To do
Development

No branches or pull requests

2 participants