Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tables for BWWC are not resizing and have unexpected scroll behavior. #127

Open
lucyq opened this issue Apr 15, 2019 · 1 comment
Open
Assignees

Comments

@lucyq
Copy link
Member

lucyq commented Apr 15, 2019

Tables when configured for BWWC are not resizing. The cells also scroll independently of the category headers, as shown in the screenshot.

Screen Shot 2019-04-15 at 2 00 16 PM

@globusharris
Copy link

Some of this was due to Lucy's browser specifically, but I believe the general scrolling issues are partially an issue with handsontable itself:

  • Issue with last table on page only half rendering is resolved by specifying width parameter in table <hot_parameters> in <client/app/data/bwwc.js>.
  • By specifying width you no longer render any of table outside of that width and scroll bars are automatically removed.

I.e. it's a catch-22.

Resolved by forcing instructions card that tables are embedded in to always be wide enough that you don't need a scroll bar, so that full table is always rendered.

This is not the prettiest, since you don't want to center based on that table as it would then push the rest of the cards on the screen to the center of the horizontal scrolling and it would be potentially hard for the user to locate them on a small enough screen. Instead, all cards are set based on the left margin. It looks ok unless you resize to a larger window without refreshing, at which point the centering looks bad. I'm calling this good for now unless people have strong opinions otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants