Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work on IE 10 (maybe other versions too) #7

Open
yyunikov opened this issue Jan 22, 2015 · 6 comments · May be fixed by #8
Open

Does not work on IE 10 (maybe other versions too) #7

yyunikov opened this issue Jan 22, 2015 · 6 comments · May be fixed by #8

Comments

@yyunikov
Copy link

When I test this on IE 10, I get the following error in script:

SCRIPT5007: Unable to get property 'userid' of undefined or null reference
so-card-widget.min.js, line 4 character 1647

Here is how the div look like:

<div id="so-card-widget" data-userid="1889928" data-theme="default"></div>

The script I'm using:

<script type="text/javascript" src="//mudassir0909.github.io/stackoverflow-card/dist/1.0.0/so-card-widget.min.js"></script>

Any suggestions?

@mudassir0909
Copy link
Owner

Looks like Element.dataset is not supported in IE < 11. This answer should fix this problem.

Can you create a PR for this ? If not then I'll fix this during weekend

@yyunikov
Copy link
Author

Yes, I have created PR. Please take a look.

@mudassir0909
Copy link
Owner

Cool, Thanks! merging it right away

@yyunikov yyunikov linked a pull request Jan 22, 2015 that will close this issue
@mudassir0909 mudassir0909 reopened this Jan 22, 2015
@mudassir0909
Copy link
Owner

reopening, one minor change needed

@yyunikov
Copy link
Author

Ok, no problem, I think min version should be generated with Grunt as well. Probably I've commited in wrong directory.

@mudassir0909
Copy link
Owner

yes min version will be generated by grunt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants