Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A bug by static variables in RunMainLoop() #329

Open
taehyunkim1527 opened this issue Oct 20, 2022 · 0 comments
Open

A bug by static variables in RunMainLoop() #329

taehyunkim1527 opened this issue Oct 20, 2022 · 0 comments

Comments

@taehyunkim1527
Copy link

taehyunkim1527 commented Oct 20, 2022 •
edited
Loading

Dear contributors,

RunMainLoop() in mtcp/src/core.c:761 is supposed to be executed per core, but has static variables, "static uint16_t len, static uint8_t *pktbuf" at line 787 and 788 thereby being not thread-safe and occurring unexpected problems.
I think just removing the keyword "static" will be okay. Please consider any changes to fix the problem.
Thank you
yasuhironet added a commit to yasuhironet/mtcp that referenced this issue Oct 15, 2024
@yasuhironet
incorporating
c15f1ce 
mtcp-stack/mtcp mtcp-stack#329: A bug by static variables in RunMainLoop()
by taehyunkim1527.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@taehyunkim1527