Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove need to pass GraphQL endpoint on calls of Evaluator #324

Closed
nmadruga opened this issue Apr 28, 2021 · 1 comment
Closed

Remove need to pass GraphQL endpoint on calls of Evaluator #324

nmadruga opened this issue Apr 28, 2021 · 1 comment
Labels
Epic #6: Query Syntax and Action plugin Query syntax and Action plugin importance: Should have Issue that should be included, not needed in MVP

Comments

@nmadruga
Copy link
Contributor

Yeah, but if you're passing an external URL in the query expression, you should be able to omit the endpoint field in the graphQLConnection object that you pass in, and the evaluator should still work, hence we should make sure there is a test that handles that case.

(Use case: if using the evaluator for something else (i.e. not IRIMS), you might not even have a local GraphQL connection, so why require an endpoint field for external queries?)

Originally posted by @CarlosNZ in #321 (comment)
@nmadruga nmadruga added Epic #6: Query Syntax and Action plugin Query syntax and Action plugin importance: Should have Issue that should be included, not needed in MVP labels Apr 28, 2021
@CarlosNZ
Copy link
Collaborator

Also covered by #1001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Epic #6: Query Syntax and Action plugin Query syntax and Action plugin importance: Should have Issue that should be included, not needed in MVP
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@CarlosNZ @nmadruga