Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregate from Path will fail in certain aggregation process when certain samples have non-complete subworkflow #1002

Open
gongyixiao opened this issue Jan 26, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@gongyixiao
Copy link
Collaborator

gongyixiao commented Jan 26, 2024

Below lines of code/script will fail when doing aggregate from path, and have samples haven't finished corresponding subworkflows.
The goal of aggregate from path is to leverage whatever have already completed samples/subworkflows to construct a cohort to the best of it can. It was designed to tolerate missing samples/subworkflows and aggregate whatever there is.
Since below scripts specifically naming files, instead of using wildcard like the examples at the end here shows, the process will fail since aggrgate will create invalid link based on the path, which will be ignored by using wildcard but error will raise when specifying file names.

awk '\$1 ~ /^#/ && FNR < NR {next;}{print}' ${bedpeFiles} > sv_germline.bedpe

awk 'FNR==1 && NR!=1{next;}{print}' ${hrdetectFiles} > hrdetect.tsv

awk '\$1 ~ /^#/ && FNR < NR {next;}{print}' ${bedpeFiles} > sv_somatic.bedpe

And for loops in the script block of this process
https://github.com/mskcc/tempo/blob/develop/modules/process/Aggregate/CohortRunMultiQC.nf

Successful examples:


awk 'FNR==1 && NR!=1{next;}{print}' lohhla/*HLAlossPrediction_CI.txt > HLAlossPrediction_CI.txt

@gongyixiao gongyixiao added the enhancement New feature or request label Jan 26, 2024
@gongyixiao gongyixiao added this to the 2.0 milestone Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants