Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client-side check for bookmarks should not say OUT_OF_BOOKMARK_QUOTA if the verse has already been bookmarked #30

Open
mshumayl opened this issue Apr 19, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@mshumayl
Copy link
Owner

As per title. The offending lines are in VerseCard.tsx

//BUG: TODO: This should not display if the user has already bookmarked this. Deferring bug fix to another time.
      const message = "You are out of bookmarks quota. Remove existing bookmarks to add more."
      const result = "OUT_OF_BOOKMARK_QUOTA"
      if (setBookmarkResultCallback && setBookmarkMessageCallback) {
        setBookmarkResultCallback(result);
        setBookmarkMessageCallback(message);
      }

This can be fixed by checking if the database contains this saved verse in the same code block as the above.

@mshumayl mshumayl added the bug Something isn't working label Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant