Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] No highlighting for module/instance name #472

Open
michaelw618 opened this issue Mar 21, 2024 · 2 comments
Open

[BUG] No highlighting for module/instance name #472

michaelw618 opened this issue Mar 21, 2024 · 2 comments
Labels

Comments

@michaelw618
Copy link

Describe the bug
Module and instance name highlighting does not work if parameter assignment starts at the line after module name:

image

Environment (please complete the following information):

  • OS: Windows 10 Pro 10.0.19045
  • VS Code version 1.87.2
  • Extension version v1.13.2
  • color themes dark

Steps to reproduce
use code from screen shot above in a .sv file

Log
N/A

Expected behavior
I expect that the module name <my_module> appears in blue and the instance name <u_my_module> in light blue/cyan

Actual behavior
see above

@OmarElfouly
Copy link
Contributor

Hello @mshr-h

I hope all is well on your side :)

I noticed that in systemverilogs case we are using the .yaml to generate the json instead of just the json so i wanted to ask if there was a specific reason we are doing so.

Also I am pretty sure the issue is the use of
[ \\t\\r\\n]
Which is:
Screenshot from 2024-10-28 11-34-41

instead of
[ \t\r\n]
Which is
Screenshot from 2024-10-28 11-35-44

@mshr-h
Copy link
Owner

mshr-h commented Oct 28, 2024

@OmarElfouly
The reason we use yaml instead of json is human readability.
PRs are always welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants