You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For large projects containing many makefiles, it would help the user out if checkmake automatically recursed over directories.
Basically, use Go's builtin filepath Walk functionality, and ignore any non-directory files that do not match the conventional POSIX, GNU, or BSD makefile name patterns. Case insensitive.
As a workaround, the user can supply a UNIX find command for this, though that breaks in many Windows contexts, and requires the user to maintain a UNIX find command, which is notoriously fragile.
This probably works as intended on WSL and other POSIX sh environments. But I'd love to see checkmake just do this automatically with directory paths, e.g. checkmake ., similar to how other modern linters behave.
Hilariously, that find command violates checkmake's default maxbodylength of 5 lines.
Also, checkmake does not currently preface its warnings with the name of the filepath to the makefile in question. So for large projects with many makefiles, the resulting linting report is unclear.
The text was updated successfully, but these errors were encountered:
For large projects containing many makefiles, it would help the user out if checkmake automatically recursed over directories.
Basically, use Go's builtin filepath Walk functionality, and ignore any non-directory files that do not match the conventional POSIX, GNU, or BSD makefile name patterns. Case insensitive.
As a workaround, the user can supply a UNIX find command for this, though that breaks in many Windows contexts, and requires the user to maintain a UNIX find command, which is notoriously fragile.
This probably works as intended on WSL and other POSIX sh environments. But I'd love to see checkmake just do this automatically with directory paths, e.g.
checkmake .
, similar to how other modern linters behave.Makefile:
Usage:
make checkmake
.Hilariously, that find command violates checkmake's default maxbodylength of 5 lines.
Also, checkmake does not currently preface its warnings with the name of the filepath to the makefile in question. So for large projects with many makefiles, the resulting linting report is unclear.
The text was updated successfully, but these errors were encountered: