Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate out the distance calculations #444

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zebmason
Copy link
Contributor

@zebmason zebmason commented Aug 2, 2020

By removing branching this may make the calculations faster (branch prediction may disagree). Can add in unit tests.

@weshinsley Let me know if you are interested and I'll do further development.

@zebmason zebmason force-pushed the distance branch 7 times, most recently from 7c40b93 to 4c1a6af Compare August 5, 2020 16:05
@zebmason
Copy link
Contributor Author

zebmason commented Aug 5, 2020

This fixes #447

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Looks like the wrong scale in distance calculations (periodic)
1 participant