You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It does vary between instances, I had a look about a month ago but there were too many PRs looking like causing a conflict. If #405 goes in I'll look at extracting out a set of methods of the form
void Builder::set_pixel(Vector2<float>& location)
{
if (!output_)
return;
Vector2<int> pixel(location * scale_ - min_);
if (!bounds_.contains(pixel))
return;
Or something. I was thinking more in the direction of extracting out the common conditional logic (tentatively called location_is_in_bounds). Maybe also a "location_to_pixel_position" function. Then keeping the adjustment of the variable in the host function...
Either way, minor details aside, I think we have a very similar sort of solution in mind.
In Update.cpp we have this sort of logic copy-pasted a few times:
There are some minor variations, and a solution to this ticket should account for that.
The text was updated successfully, but these errors were encountered: