Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tibble 3.0.0 breaking changes #15

Closed
mps9506 opened this issue Apr 1, 2020 · 2 comments · Fixed by #17
Closed

tibble 3.0.0 breaking changes #15

mps9506 opened this issue Apr 1, 2020 · 2 comments · Fixed by #17
Assignees
@mps9506
Labels
bug Something isn't working

Comments

@mps9506
Copy link
Owner

mps9506 commented Apr 1, 2020

This is a little ambiguous right now. The 3.0.0 release of tibble caused some breaking changes when building tbrf. See CRAN results:
https://cran.r-project.org/web/checks/check_results_tbrf.html
@mps9506 mps9506 added the bug Something isn't working label Apr 1, 2020
@mps9506 mps9506 self-assigned this Apr 1, 2020
mps9506 added a commit that referenced this issue Apr 1, 2020
@mps9506
fix #15
cc4369f 
use tibble::enframe() to convert named vectors to empty tibble in list_NA()
@mps9506
Copy link
Owner Author

mps9506 commented Apr 6, 2020 •
edited
Loading

Need to update Appveyor.yml see :krlmlr/r-appveyor#167

environment:
  NOT_CRAN: true
  # env vars that may need to be set, at least temporarily, from time to time
  # see https://github.com/krlmlr/r-appveyor#readme for details
  USE_RTOOLS: true
  R_REMOTES_STANDALONE: true
  # PKGTYPE: both
  # Adapt as necessary starting from here
  matrix:
  - R_VERSION: devel
    GCC_PATH: mingw_32
    PKGTYPE: source

  - R_VERSION: devel
    R_ARCH: x64
    GCC_PATH: mingw_64
    PKGTYPE: both

@mps9506
Copy link
Owner Author

mps9506 commented Apr 8, 2020

This builds fine on r-devel in r-hub winbuilder and all other platforms. Releasing to CRAN.

@mps9506 mps9506 closed this as completed Apr 8, 2020
@mps9506 mps9506 mentioned this issue Apr 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mps9506 mps9506

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tibble fix mps9506/tbrf
1 participant
@mps9506