You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Input-Output (IO) should be independent from this library. This concerns the image, png, byteorder and nom crates.
itertools is used only once for the izip function, to zip 3 vectors in the same loop. It probably isn't worth the dependency.
num-traits is only used in dso candidates selection implementation for the Number trait. Maybe there is a way of doing it without the dependency. Maybe it shouldn't even be generic since for now, this implementation is only done for u16 gradient images.
Random number generation is only used in candidates::dso. DSO is also the cause of num-traits, and one implementation should not bring too many dependencies. It might be a good idea to make candidates selection a trait somehow, and separate coarse to fine and dso's implementations into another code base?
The text was updated successfully, but these errors were encountered:
image
,png
,byteorder
andnom
crates.itertools
is used only once for theizip
function, to zip 3 vectors in the same loop. It probably isn't worth the dependency.num-traits
is only used in dso candidates selection implementation for theNumber
trait. Maybe there is a way of doing it without the dependency. Maybe it shouldn't even be generic since for now, this implementation is only done for u16 gradient images.candidates::dso
. DSO is also the cause ofnum-traits
, and one implementation should not bring too many dependencies. It might be a good idea to make candidates selection a trait somehow, and separate coarse to fine and dso's implementations into another code base?The text was updated successfully, but these errors were encountered: