Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove (and fix) clippy locally disabled features #3

Open
3 tasks
mpizenberg opened this issue Mar 25, 2019 · 0 comments
Open
3 tasks

Remove (and fix) clippy locally disabled features #3

mpizenberg opened this issue Mar 25, 2019 · 0 comments

Comments

@mpizenberg
Copy link
Owner

They are easily found by searching for "clippy". Mostly, the disabled features are:

  • excessive_precision: typically, f32 floats with too many figures. Those should be removed when the corresponding code becomes generic over f32 and f64.
  • many_single_char_names: happens in most "bloc" functions where a 1-letter name is given for each sub pixel to make equations readable. It should probably be smarter to use at least 2 letters though. Something like tl, bl, tr, br for top left, bottom left, etc.
  • cast warnings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant