-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
need help: test fails on darwin x86-64 (but curiously not aarch64) #4
Comments
Can you give some more details about the used BLAS library? Since the must be a reason. Nevertheless I seem to be safe to adjust the tolerance a bit. Line 258 in 44a34de
to 1D3 ,
|
Hey, on Nixpkgs (Which also distributes software for both Darwin platforms) we experience exactly the same issue with x86_64-darwin (and not aarch64-darwin):
I don't have available the floating points we had on aarch64-darwin unfortunately (because there the tests passed). Our https://cache.nixos.org/log/vdk8dns4jvy1n7w1djhdy7i1a3ph37p0-openblas-0.3.27.drv I don't have personally an x86_64-darwin machine, so I am able to only use our CI which is very slow for these platforms unfortunately, so I won't be able to help much in debugging. I hope the debugging information I provided helps a bit. |
It's the same blas version FWIW. I am using Nix to build qrupdate. |
It seems that the tolerances need to be adjusted a bit more. I'll prepare a patch during the next days. But the solution seems to adjust this line Line 258 in 44a34de
|
The test
test_tch1dn/zch1dn
fails on x86-64 versions of macOS, but not aarch64.The residual errors are worse overall on the former, but it is only large enough to tip over into a failure for
zch1dn
.Is this too serious of a problem? Is there a way for me to adjust the threshold?
x86-64 test log
aarch64 test log
The text was updated successfully, but these errors were encountered: