Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Firefox Sync #131

Open
dannycolin opened this issue Jan 1, 2020 · 4 comments
Open

Add support for Firefox Sync #131

dannycolin opened this issue Jan 1, 2020 · 4 comments
Labels
Discussion The intent of the Discussion tag is to precisely that Enhancement New feature or request P3 We'll want to implement it at some point in the future, but it's not near-term roadmap material

Comments

@dannycolin
Copy link
Collaborator

The goal of this feature is to synchronize the webext preferences with the user FxA.

(See: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/storage/sync)

@dannycolin dannycolin added the Enhancement New feature or request label Jan 1, 2020
@WesleyBranton
Copy link
Collaborator

Potentially a good idea. Naturally, the saved questions list should probably be kept in the local storage.

@dannycolin
Copy link
Collaborator Author

dannycolin commented Jan 1, 2020

Potentially a good idea. Naturally, the saved questions list should probably be kept in the local storage.

There's a storage limit in Sync. However, I wonder if there'd be enough space to Sync the questions ID that have been opened. It shouldn't take a lot of space. Anyway, lets just focus on the preferences for now.

@WesleyBranton
Copy link
Collaborator

So, I was thinking about this some more and I'm not sure that adding support for Firefox Sync is a good idea.

There are too many things that users may want to customize depending on the device. For example, maybe they don't want every device to be dark mode. Maybe they want to reduce the frequency of the question checks on mobile to reduce data usage. Maybe they want the sidebar on their computer, but not their laptop.

That's just my thoughts on it.

@WesleyBranton WesleyBranton added the Discussion The intent of the Discussion tag is to precisely that label Jan 4, 2020
@dannycolin
Copy link
Collaborator Author

There are too many things that users may want to customize depending on the device. For example, maybe they don't want every device to be dark mode. Maybe they want to reduce the frequency of the question checks on mobile to reduce data usage. Maybe they want the sidebar on their computer, but not their laptop.

Those are good points to consider. Maybe we could add an option to let the users choose if they want to sync or not their preferences across multiple devices.

@dannycolin dannycolin added the P3 We'll want to implement it at some point in the future, but it's not near-term roadmap material label Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion The intent of the Discussion tag is to precisely that Enhancement New feature or request P3 We'll want to implement it at some point in the future, but it's not near-term roadmap material
Projects
None yet
Development

No branches or pull requests

2 participants