Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExtensionSettings and removing add-ons #1124

Open
as-qwerty opened this issue Jun 28, 2024 · 4 comments
Open

ExtensionSettings and removing add-ons #1124

as-qwerty opened this issue Jun 28, 2024 · 4 comments

Comments

@as-qwerty
Copy link

If I specify the following in Extension settings:

  "*": {
    "blocked_install_message": "message",
    "installation_mode": "blocked"

all installed extensions (except those listed in "installation_mode": "allowed") will be removed. This is correct.

but if I specify something like this:

  "*": {
    "blocked_install_message": "message",
    "installation_mode": "allowed",
    "allowed_types": ["locale","dictionary"]

all installed add-ons (except those listed in "installation_mode": "allowed", and any languages and dictionaries ) will be blocked (grayed out), but not removed. This is not obvious, because if I wanted to remove or block installed extensions (for the user it is the same thing), I would use "blocked".

Is it possible to specify what to do with extensions that are not explicitly described as "blocked" in the policy: "gray out" or "do nothing"?

@mkaply
Copy link
Collaborator

mkaply commented Jun 28, 2024

That actually sounds like a bug (that they aren't uninstalled)

Chrome introduced "removed" to explicitly remove things

https://support.google.com/chrome/a/answer/9867568?hl=en

Do you want them disabled or removed?

@as-qwerty
Copy link
Author

It seems right to me: delete if I specified "blocked" and do nothing if I specified nothing. Otherwise "blocked" is identical to "not specified"
I think there may be situations when you want to keep previously installed extensions for users, but not allow installation of new ones.
Maybe add a separate ExtensionSettings option that would allow selecting the action for already installed extensions (remove, blocked or do nothing)? That would be more flexible.

@mkaply
Copy link
Collaborator

mkaply commented Jul 1, 2024

The tricky part is making this change without impacting the old behavior.

I wonder if I need to add a version flag to this JSON?

I'm going to look at Chrome to see exactly what they do.

@as-qwerty
Copy link
Author

I think the best thing to do is this:

  1. leave the default behavior as it is now
  2. Add a new option that allows you to specify what to do with extensions that are not explicitly listed as “blocked”: delete, gray out, or do nothing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants