Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox View #1078

Open
Jee-Hex opened this issue Mar 8, 2024 · 3 comments
Open

Firefox View #1078

Jee-Hex opened this issue Mar 8, 2024 · 3 comments

Comments

@Jee-Hex
Copy link

Jee-Hex commented Mar 8, 2024

Add a policy for the following:

firefox view icon (enable/disable) browser.tabs.firefox-view (true/false)

This can be set via the Preferences policy. I'm not going to add an explicit policy at this time for Firefox View

Originally posted by @mkaply in #964 (comment)


browser.tabs.firefox-view and browser.tabs.firefox-view-next were removed in FF123 and the prefs in about:config currently don't control anything (bug 1882114 comment 2). Will you to able to reconsider adding a policy for Firefox View?

@mkaply
Copy link
Collaborator

mkaply commented Mar 8, 2024

We consider Firefox an integral (and useful) feature in Firefox now.

If a user wants to remove it, they can right click and remove the icon.

Can I ask why you want to remove it?

@Jee-Hex
Copy link
Author

Jee-Hex commented Mar 10, 2024

Can I ask why you want to remove it?

Because it is a "feature" that prompts users to sign up for a Firefox Account, adds a bunch of whitespaces in the process, and doesn't do anything new (at least for me anyway) on top of the old Library. It's pretty telling when the recently closed tabs history section in fxview-next has a Show all history button that simply points you back to... the Library?

If a user wants to remove it, they can right click and remove the icon.

How would you expect users to deploy this? I mean I could always modify the default value of browser.uiCustomization.state with something like

{
  "policies": {
	"Preferences": {
		"browser.uiCustomization.state": {
			"Value": "{\"placements\":{\"widget-overflow-fixed-list\":[],\"unified-extensions-area\":[],\"nav-bar\":[\"back-button\",\"forward-button\",\"stop-reload-button\",\"customizableui-special-spring1\",\"urlbar-container\",\"customizableui-special-spring2\",\"save-to-pocket-button\",\"downloads-button\",\"fxa-toolbar-menu-button\",\"unified-extensions-button\"],\"toolbar-menubar\":[\"menubar-items\"],\"TabsToolbar\":[\"tabbrowser-tabs\",\"new-tab-button\",\"alltabs-button\"],\"PersonalToolbar\":[\"import-button\",\"personal-bookmarks\"]},\"seen\":[\"save-to-pocket-button\",\"developer-button\"],\"dirtyAreaCache\":[],\"currentVersion\":19,\"newElementCount\":2}",
			"Status": "default"
		}
	}
  }
}

, but that would also mean I would have to keep up with changes to CustomizableUI.sys.mjs every now and then because the value of browser.uiCustomization.state is empty by default. I also can't just deploy, for example, only the TabsToolbar part because Firefox would just treat the value as invalid.

You do have a policy for something even more minute (the home button) anyway. It would be nice if users can depoly this in a simplier way.

@mkaply
Copy link
Collaborator

mkaply commented Mar 21, 2024

We're resolving the issue that the Sync login appears on the page, but at this point, we don't have plans to add a policy to remove Firefox View.

I'll add it to the backlog.

FYI, there's a lot of new features coming to that page that will make it better than library (the search is already better).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants