You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Here the bench in #[cfg(any(test, feature = "bench"))] does not refer to the bench feature of neqo_common, but to the bench feature of the crate executing qerror.
qerror is used in mozilla-central's neqo_glue. But neqo_glue does not have the bench feature, thus the compiler throws a warning.
I see the following ways forward:
Introduce a fake no-op bench feature to neqo_glue.
Remove the conditional log initialization on bench.
The text was updated successfully, but these errors were encountered:
Logging macros like
neqo_common::log::qerror
call::neqo_common::log::init
when either testing, or benchmarking.neqo/neqo-common/src/log.rs
Lines 55 to 61 in e006a7d
Here the
bench
in#[cfg(any(test, feature = "bench"))]
does not refer to thebench
feature ofneqo_common
, but to thebench
feature of the crate executingqerror
.qerror
is used in mozilla-central'sneqo_glue
. Butneqo_glue
does not have thebench
feature, thus the compiler throws a warning.I see the following ways forward:
bench
feature toneqo_glue
.bench
.The text was updated successfully, but these errors were encountered: