You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The integration test run in CI currently runs against a debug build. This disables its STRICT_LOG_COUNTS var which was built to ensure the number of log messages aren’t larger than we expect.
These log counts should be enforced in CI. It might not be feasible to run them against a release build (which will add to our CI build times): we could at least configure the debug build to produce the same log output as release and check that instead. This would require altering the test’s disabling of STRICT_LOG_COUNTS in debug builds.
Hey Philip Jenvey ! What are your thoughts on us proceeding on this one? Would you like me to land a patch that adjusts the STRICT_LOG_COUNTS config? We can discuss this one further next week as well. Perhaps we can do a few test builds to see what the output looks like and what impact it has on the build times.
The integration test run in CI currently runs against a debug build. This disables its
STRICT_LOG_COUNTS
var which was built to ensure the number of log messages aren’t larger than we expect.These log counts should be enforced in CI. It might not be feasible to run them against a
release
build (which will add to our CI build times): we could at least configure thedebug
build to produce the same log output as release and check that instead. This would require altering the test’s disabling ofSTRICT_LOG_COUNTS
indebug
builds.┆Issue is synchronized with this Jira Bug
The text was updated successfully, but these errors were encountered: