Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

204: No Content #54

Open
kevinahuber opened this issue Sep 13, 2016 · 1 comment
Open

204: No Content #54

kevinahuber opened this issue Sep 13, 2016 · 1 comment

Comments

@kevinahuber
Copy link

Fantastic service! Very happy to see a node version of the PWS that is pushing the limits of what it can be. I really like your additional scraping services.

In Google's PWS, if a site returns 204 (no-content), the service bails and the url is not shown in scanners:
https://github.com/google/physical-web/blob/master/web-service/helpers.py#L217

It would be great to follow that standard here- right now magnent scanners just show fetching content.. indefinitely.

@arcturus
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants