Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all headers to .hpp #994

Closed
sea-bass opened this issue Dec 18, 2024 · 2 comments
Closed

Update all headers to .hpp #994

sea-bass opened this issue Dec 18, 2024 · 2 comments
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@sea-bass
Copy link
Contributor

After moveit/moveit2#3113, this repo should update all the MoveIt .h headers to .hpp.

Great chance for someone to help out here!

@sea-bass sea-bass added the good first issue Good for newcomers label Dec 18, 2024
@mikeferguson mikeferguson added the help wanted Extra attention is needed label Dec 18, 2024
@CihatAltiparmak
Copy link
Member

CihatAltiparmak commented Dec 20, 2024

Hi, i want to help you out. For this, we should minimize warnings which is due to other non-updated repositories like moveit_task_constructor and moveit_visual_tools.

I've also sent PR of these repositories to remove obsolete headers. I believe it would be nice to merge below PRs before this PR. I've converted PRs to draft in case blindly merging, but feel free to convert to ready.

Finally, we should also think about not only updating headers but also updating documentation.

@CihatAltiparmak
Copy link
Member

CihatAltiparmak commented Dec 31, 2024

Let's close this out bc looks like it's successfully sorted out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants