Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]: start span(s) during subscription #4

Open
getlarge opened this issue Sep 22, 2023 · 1 comment
Open

[feat]: start span(s) during subscription #4

getlarge opened this issue Sep 22, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@getlarge
Copy link
Member

getlarge commented Sep 22, 2023

Is your feature request related to a problem? Please describe.

Create span during subscription to enable performance monitoring of the processing.

Describe the solution you'd like

In getHandleSubscribePatch start a span when the patched handleSubscribe is invoked and end it when done callback (from handleSubscribe arguments) is called.

Questions pending ?

  • Should only one span be started for all subscriptions topic ?
  • Beyond the client connection details, what should be added in the span attributes ?
    • if this is a restored subscription ?
    • topic(s)
  • How should the span(s) be named ? Probably using the suffix process as specified in OpenTelemetry semantic conventions.
@getlarge getlarge added the enhancement New feature or request label Sep 22, 2023
@getlarge getlarge self-assigned this Sep 22, 2023
@robertsLando
Copy link
Member

Should only one span be started for all subscriptions topic ?

Could you explain this? You mean that if a sub contains multiple topics? In that case I would focusing on the time needed to process an entire sub packet independently from the topics

Beyond the client connection details, what should be added in the span attributes ?

Subscription qos too, consider also that 128 is considered an error (failed sub)

How should the span(s) be named ? Probably using the suffix process as specified in OpenTelemetry semantic conventions.

No clue about this as I'm not very expert about OpenTelemetry, I let you decide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants