Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BaseBundler renaming #434

Merged
merged 5 commits into from
May 14, 2024
Merged

BaseBundler renaming #434

merged 5 commits into from
May 14, 2024

Conversation

MathisGD
Copy link
Contributor

No description provided.

@MathisGD MathisGD changed the base branch from main to feat/base May 13, 2024 22:08
@MathisGD MathisGD changed the title `BaseBundler renaming BaseBundler renaming May 13, 2024
MerlinEgalite
MerlinEgalite reviewed May 14, 2024
View reviewed changes
Copy link
Contributor

@MerlinEgalite MerlinEgalite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose using CoreBundler instead

src/ERC4626Bundler.sol Outdated Show resolved Hide resolved
@MathisGD MathisGD self-assigned this May 14, 2024
@MathisGD MathisGD mentioned this pull request May 14, 2024
Merged
@MathisGD MathisGD linked an issue May 14, 2024 that may be closed by this pull request
Inconsistent naming of "MainnetLib" #429
Open
Rubilmax
Rubilmax approved these changes May 14, 2024
View reviewed changes
Copy link
Collaborator

@Rubilmax Rubilmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonderful!

@MathisGD MathisGD merged commit 980905d into feat/base May 14, 2024
10 checks passed
@MathisGD MathisGD deleted the style/rootbundler branch May 14, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MerlinEgalite MerlinEgalite MerlinEgalite approved these changes

@QGarchery QGarchery QGarchery approved these changes

@Rubilmax Rubilmax Rubilmax approved these changes

@adhusson adhusson Awaiting requested review from adhusson

@Jean-Grimal Jean-Grimal Awaiting requested review from Jean-Grimal

Assignees

@MathisGD MathisGD

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent naming of "MainnetLib"
4 participants
@MathisGD @Rubilmax @QGarchery @MerlinEgalite