Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chinese subtitle downloading issue for the provider "Assrt" #2761

Closed
xuanguang opened this issue Nov 16, 2024 · 4 comments
Closed

Chinese subtitle downloading issue for the provider "Assrt" #2761

xuanguang opened this issue Nov 16, 2024 · 4 comments

Comments

@xuanguang
Copy link

Describe the bug
Lots of Chinese subtitles cannot be downloaded, but they exist in Assrt (http://assrt.net).

In my case, for example, the TV show "All Creatures Great & Small (2020)", S05E01, two subtitles can be found from the Assrt website, but none of them can be downloaded.
From the log I can see,
BAZARR Skipping <AssrtSubtitle: 不知道 [<Language: alpha3=zho>]>, because it doesn't match our series/episode|
but in fact, they are the right ones.
I tried the API (which was copied from the Bazarr log) from my web browser, and found the response as the figure below.
It seems the wrong key work is used: the "videoname" is not the correct name key, while the "native_name" is.
image

Of course not only this TV show in Assrt, but lots of, I found that they have such similar issues.

To Reproduce
Steps to reproduce the behavior:

  1. Add "All Creatures Great & Small (2020)" into "Series"
  2. Configure the downloading language as "Chinese".
  3. Try to download (automatically or manually) the subtitle of S05E01, as the figure below. You can find that no subtitle will be downloaded.
    image
  4. But the right subtitles exist on the Assrt website (http://assrt.net), as shown below.
    image

Expected behavior
The right subtitles are matched and downloaded correctly.

Screenshots
Screenshots are attached above.

Software (please complete the following information):

  • Bazarr: [1.4.5]
  • Radarr version [4.4.4.7068]
  • Sonarr version [4.0.10.2544]
  • OS: [Ubuntu 24.04, Linux-6.8.12-1-pve-x86_64-with-glibc2.39]

Additional context
From the Bazarr log, I saw the issue should come from the API response keyword, but not sure, please check and help, thanks!

@xuanguang
Copy link
Author

Maybe there should be some check logics here.

I also found that sometimes the key "videoname" is configured correctly.
But in Chinese, the meaning of the word "不知道" in my first example is "unknown", which is the value of "videoname" in the example case. So for such cases, if the "videoname" is "不知道"(which means "unknown"), or other meaningless value, we can try the "native_name" again.
Thanks.

@morpheus65535
Copy link
Owner

Sorry for the delay. What are those meaningless values you're referring to? I don't read Chinese so it's hard to tell. If you provide a list, I can try to add a check to try native_name if found in videoname.

@xuanguang
Copy link
Author

Hi @morpheus65535, thanks for your replying.
Here, it responds the "videoname" as "不知道", which means "unknown".
So one value of the list should be "不知道".
But for other meaningless values, I haven't found any yet. So you can add this first, I will update more if I find in the future.
Thanks.

@morpheus65535
Copy link
Owner

Should be improved in upcoming beta. Let me know if it helps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants