-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chinese subtitle downloading issue for the provider "Assrt" #2761
Comments
Maybe there should be some check logics here. I also found that sometimes the key "videoname" is configured correctly. |
Sorry for the delay. What are those meaningless values you're referring to? I don't read Chinese so it's hard to tell. If you provide a list, I can try to add a check to try |
Hi @morpheus65535, thanks for your replying. |
Should be improved in upcoming beta. Let me know if it helps! |
Describe the bug
Lots of Chinese subtitles cannot be downloaded, but they exist in Assrt (http://assrt.net).
In my case, for example, the TV show "All Creatures Great & Small (2020)", S05E01, two subtitles can be found from the Assrt website, but none of them can be downloaded.
From the log I can see,
BAZARR Skipping <AssrtSubtitle: 不知道 [<Language: alpha3=zho>]>, because it doesn't match our series/episode|
but in fact, they are the right ones.
I tried the API (which was copied from the Bazarr log) from my web browser, and found the response as the figure below.
It seems the wrong key work is used: the "videoname" is not the correct name key, while the "native_name" is.
Of course not only this TV show in Assrt, but lots of, I found that they have such similar issues.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The right subtitles are matched and downloaded correctly.
Screenshots
Screenshots are attached above.
Software (please complete the following information):
Additional context
From the Bazarr log, I saw the issue should come from the API response keyword, but not sure, please check and help, thanks!
The text was updated successfully, but these errors were encountered: