Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-existent parameters to Testplan class do not cause error #291

Open
ryan-collingham opened this issue Oct 8, 2019 · 0 comments
Open
Labels
bug Something isn't working

Comments

@ryan-collingham
Copy link
Contributor

ryan-collingham commented Oct 8, 2019

I noticed that adding complete garbage parameters to the Testplan class constructor does not cause an error. E.g.:

import testplan
testplan.Testplan(
    name="MyPlan",
    foobarbaz=True)

I would expect the foobarbaz to cause a TypeError but it does not. This may cause confusion in case of a minor typo of a parameter leading to unexpected behaviour.

I haven't checked but likely this problem isn't specific to the Testplan class itself but might be due to the common configuration validation. It should be set up to raise an Exception if unrecognised parameters are passed.

@ryan-collingham ryan-collingham self-assigned this Oct 8, 2019
@ryan-collingham ryan-collingham added the bug Something isn't working label Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant