Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable MSERIALIZE_MAKE_DERIVED unittests on windows #134

Open
erenon opened this issue Aug 24, 2021 · 0 comments
Open

Enable MSERIALIZE_MAKE_DERIVED unittests on windows #134

erenon opened this issue Aug 24, 2021 · 0 comments
Labels
good first issue Good for newcomers

Comments

@erenon
Copy link
Contributor

erenon commented Aug 24, 2021

The following macro invocations fail on MSVC:

MSERIALIZE_MAKE_DERIVED_STRUCT_TAG(Derived1, (Base2, Base3), d, e)
MSERIALIZE_MAKE_DERIVED_STRUCT_SERIALIZABLE(Derived1, (Base2, Base3), d, e)

They appear in tag.cpp, roundtrip.cpp, visit.cpp.

Error is:

not enough arguments for function-like macro invocation 'MSERIALIZE_FOREACH_3'.

It is suspected that (Base2, Base3) does not expand properly, because of the nonstandard msvc preprocessor.
The actual user-facing functionality (BINLOG_ADAPT_DERIVED) works. (MSERIALIZE_EXPAND does the trick there for some reason)

Task: Fix the affected macros on MSVC, remove the #ifndef _WIN32 guards from the files above.

@erenon erenon added the good first issue Good for newcomers label Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant