Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the i_add_to_section_and_i_fill_the_form_with deprecation for Moodle 4.4 #147

Open
Julian-Tovar opened this issue Oct 4, 2024 · 1 comment

Comments

@Julian-Tovar
Copy link

Julian-Tovar commented Oct 4, 2024

Good day team,

In Moodle 4.4 this Behat step was deprecated:

And I add a "OU blog" to section "0" and I fill the form with:

In file 'tests/behat/sharedblog.feature', you can see these steps:

When I am on "Course 1" course homepage
And I add a "OU blog" to section "0" and I fill the form with:

There are three instances of that deprecation on that file alone.

I have created this patch, to ready up the Behat tests for Moodle 4.4 as far as this deprecation is concerned.
oublog_patch_Behat_4.4.patch

Let me know if this patch is acceptable or if it contains mistakes or missing parts, and if I should create a PR with it or if you apply it on your side in that case.

Thank you.

@jason-platts
Copy link
Member

Thanks for writing this. We have fixed the 4.4 issues in oublog but as we haven't finalised the internal test + release yet we have yet to push the changes publicly. We would expect to do that later this month or start of Nov.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants