-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.0.8 => 3.0.10 Error: Could not find source map for: "...\validationHelper.ts" #245
Comments
I get the same error when upgrading from 3.0.8 to 3.0.10. |
I have same issue. covered line are mismatched. |
Confirming the same issue. |
It works if I lock down |
The culprit is a regex in remap-istanbul that doesn't match the inline source maps from karma-typescript: SitePen/remap-istanbul#149. I'll cut a panic release today with '[email protected]'... |
v3.0.11 is on npm now 😊 |
😄 now this is back:
Removing all the installed packages does not help. |
I'm working on a fix in #246, feel free to try it out! |
I can confirm that 3.0.11 workarounds this final issue and allows us to be back on latest version. Thanks guys! |
Ok, so 3.0.11 works for you @baywet, but not for you @rolandjitsu? My guess is using different versions of npm gives different results now because of the |
on my local machine node 7.10.0 |
I'm running on OS X Sierra, node 8.4, npm 5.6. I've been using Yarn to install the packages though. Might be because of that. I've switched to jest for now, but I will try the PR out on some other projects where I still use karma. |
Jumping into say I'm on 3.0.11 and getting the same error as @rolandjitsu (as below from my machine.) I found this which seems to be tackling a similar problem and was resolved by moving to [email protected] https://github.com/apache/metron/pull/908 I've tried using yarn resolutions to override the dependency but it's not playing nice for some reason. I'll keep trying and report back. UPDATE: got resolutions working, forcing remap-istanbul to v0.9.6 has solved it for me. Error on my machine (before remap-instanbul resolutions solve):
|
@TimothyDespair, the PR #246 uses |
@erikbarke Just gave it a shot. Seems to be working! |
Awsesome guys, thanks!! |
Hi,
We were blocked from upgrading to 3.0.9 because of this one #226
I just tried upgrading to 3.0.10 and I'm getting a lot of errors like that.
[reporter.karma-typescript]: TypeError: Cannot read property 'text' of undefined
Might be relate to that #240
The text was updated successfully, but these errors were encountered: