From d1ba54978b7447f91066a0f7a250eafcc3d851a8 Mon Sep 17 00:00:00 2001 From: "jose.vazquez" Date: Sat, 7 Sep 2024 21:17:02 +0200 Subject: [PATCH] Fix version comparison at skip check Signed-off-by: jose.vazquez --- test/e2e/helm_chart_test.go | 2 +- test/helper/e2e/cli/helm/helm.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/test/e2e/helm_chart_test.go b/test/e2e/helm_chart_test.go index f06d154b3f..0138761785 100644 --- a/test/e2e/helm_chart_test.go +++ b/test/e2e/helm_chart_test.go @@ -236,7 +236,7 @@ var _ = Describe("HELM charts", Ordered, func() { releaseMajorVersion := strings.Split(releasedVersion, ".")[0] if releaseMajorVersion != devMajorVersion { skipped = true - Skip(fmt.Sprintf("cannot test upgrade from incompatible major release version %s to version %s", + Skip(fmt.Sprintf("cannot test upgrade from incompatible major release version %q to version %q", releaseMajorVersion, devMajorVersion)) } }) diff --git a/test/helper/e2e/cli/helm/helm.go b/test/helper/e2e/cli/helm/helm.go index 18516fc0df..f3dac11fa3 100644 --- a/test/helper/e2e/cli/helm/helm.go +++ b/test/helper/e2e/cli/helm/helm.go @@ -276,7 +276,7 @@ func GetDevelopmentMayorVersion() (string, error) { if err != nil { return "", err } - return string(majorVersion), nil + return strings.TrimSpace(string(majorVersion)), nil } func packageChart(sPath, dPath string) {