Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compressed maps sometimes detected as uncompressed #74

Closed
tsa96 opened this issue Dec 7, 2024 · 2 comments · Fixed by #85
Closed

Compressed maps sometimes detected as uncompressed #74

tsa96 opened this issue Dec 7, 2024 · 2 comments · Fixed by #85
Assignees
@tsa96

Comments

@tsa96
Copy link
Member

tsa96 commented Dec 7, 2024

I'm not sure if this is a TS header parsing thing or a Lumper thing.
@tsa96 tsa96 self-assigned this Dec 7, 2024
@GordiNoki
Copy link
Member

I believe it's a lumper issue. If you're talking about rj_quba we tried submitting before qna - it has uncompressed lumps with data, specifically LUMP_OCCLUSION(9), LUMP_AREAPORTALS(21), LUMP_PHYSDISP(28) and LUMP_MAP_FLAGS(59). They should be compressed, since this is what my re-bspzipped version has. If you have any other files with the same issue I can look into the reason behind them too.

rj_quba.zip

@tsa96
Copy link
Member Author

tsa96 commented Dec 9, 2024

Not surprised if that's the case, the only reason I thought it might not be a Lumper issue is I think I ran into it with a bspzip compressed map when preparing stuff for the last QnA. But I was in a rush then and may well have just screwed something up and compressed it wrong.

@tsa96 tsa96 transferred this issue from momentum-mod/website Jan 21, 2025
@tsa96 tsa96 moved this to Todo in Map Submission Jan 21, 2025
tsa96 added a commit that referenced this issue Jan 28, 2025
@tsa96
fix(lib): write small lumps compressed, even if lzma header increases…
1868903 
… size

Fix for #74.
We writing out lumps < 22 bytes large as compressed since the LZMA
header actually causes the lump to get larger. That causes the BSP to
fail our compression checks in the website repo.

bspzip doesn't seem to have the optimization, and such an insignificant
amount of data anyway, that there's no problem in always writing the
header.
tsa96 added a commit that referenced this issue Jan 28, 2025
@tsa96
fix(lib): write small lumps compressed, even if lzma header increases…
10342ef 
… size

Fix for #74.
We writing out lumps < 22 bytes large as compressed since the LZMA
header actually causes the lump to get larger. That causes the BSP to
fail our compression checks in the website repo.

bspzip doesn't seem to have the optimization, and such an insignificant
amount of data anyway, that there's no problem in always writing the
header.
@tsa96 tsa96 mentioned this issue Jan 28, 2025
Merged
tsa96 added a commit that referenced this issue Jan 28, 2025
@tsa96
fix(lib): write small lumps compressed, even if lzma header increases…
7c1dfa7 
… size

Fix for #74.
Closes #74

We were writing out lumps < 22 bytes large as uncompressed since the
LZMA header actually causes the lump to get larger. That causes the BSP
to fail our compression checks in the website repo.

`bspzip` doesn't seem to have our optimization, and it's such an
insignificant amount of data anyway, no problem always writing the header.
tsa96 added a commit that referenced this issue Jan 29, 2025
@tsa96
fix(lib): write small lumps compressed, even if lzma header increases…
02f62d5 
… size

Fix for #74.
Closes #74

We were writing out lumps < 22 bytes large as uncompressed since the
LZMA header actually causes the lump to get larger. That causes the BSP
to fail our compression checks in the website repo.

`bspzip` doesn't seem to have our optimization, and it's such an
insignificant amount of data anyway, no problem always writing the header.
tsa96 added a commit that referenced this issue Jan 30, 2025
@tsa96
fix(lib): write small lumps compressed, even if lzma header increases…
05ea1b3 
… size

Fix for #74.
Closes #74

We were writing out lumps < 22 bytes large as uncompressed since the
LZMA header actually causes the lump to get larger. That causes the BSP
to fail our compression checks in the website repo.

`bspzip` doesn't seem to have our optimization, and it's such an
insignificant amount of data anyway, no problem always writing the header.
@tsa96 tsa96 closed this as completed in #85 Jan 30, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in Map Submission Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsa96 tsa96

Labels
None yet
Projects
Map Submission
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix very small lumps not being compressed properly momentum-mod/lumper
2 participants
@tsa96 @GordiNoki