Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Train-data-creator doesn't use SYMBOL ID's #55

Open
SietsmaRJ opened this issue Feb 14, 2023 · 0 comments
Open

Train-data-creator doesn't use SYMBOL ID's #55

SietsmaRJ opened this issue Feb 14, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@SietsmaRJ
Copy link
Contributor

Describe the bug

Currently, due to limitations of supplied data, train-data-creator doesn't use SYMBOL ID's, but instead relies on (not-normalized) SYMBOL to map back a variant after being annotated by VEP. This could potentially cause issues as SYMBOL ID's are set, but SYMBOL is not, so SYMBOL could change at any minute.

System information

  • OS: [e.g. iOS]
  • Version: [e.g. 3.0.0]
  • Python version: [e.g. Python3.9.1]
  • Shell: [e.g. ZSH]

How to Reproduce

Steps to reproduce the behavior:

  1. cd to dir [...]
  2. Run the command [...]
  3. See error.

Expected behavior

train-data-creator uses SYMBOL ID's instead of SYMBOL. This means that process-vep should also take this into account, although mapping 1 to 1 (or 1 to many: #54 ) should not limit the use of SYMBOL ID's.

Logs

If available, the generated logging information and/or error message (can also be attached as a file if very large).

Screenshots

If applicable, add screenshots to help explain your problem.

Additional context

#51 (comment)

@SietsmaRJ SietsmaRJ added the bug Something isn't working label Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant