Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement features from django-downloadview? #18

Open
moggers87 opened this issue Oct 5, 2019 · 1 comment
Open

Implement features from django-downloadview? #18

moggers87 opened this issue Oct 5, 2019 · 1 comment
Labels
question Further information is requested

Comments

@moggers87
Copy link
Owner

See https://django-downloadview.readthedocs.io/en/1.9/overview.html

According to jazzband/django-downloadview#146 that package is dead.

The views are something we could port over. There was an attempt to add class based views to this package (see #4) but no tests were submitted.

The documentation also claims that django-sendfile supports only files that live on local filesystem. I don't think that's true, but if it is then it needs to be fixed.

If you do copy code from that project, please do the following:

  • In a code comment: add the copyright notice from django-downloadview to the module/class/function you're copying
  • In a code comment and the commit message: make a note of where you got the code from, e.g. "This was taken from django-downloadview /file/path"
@moggers87 moggers87 added the question Further information is requested label Oct 5, 2019
@moggers87
Copy link
Owner Author

https://github.com/moggers87/django-sendfile2/blob/master/django_sendfile/sendfile.py#L46

Not sure how I missed that, but it needs to go. This check should happen on the simple and development backends only. It should be possible for other backends to serve files that your Django app can't see (i.e. Apache is streaming the file from a different server)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant