Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bandpassLambda function returns transpose of documented array shape #10

Open
moeyensj opened this issue Jul 15, 2020 · 2 comments
Open

bandpassLambda function returns transpose of documented array shape #10

moeyensj opened this issue Jul 15, 2020 · 2 comments
Assignees
@moeyensj
Labels
bug Something isn't working documentation Improvements or additions to documentation duplicate This issue or pull request already exists

Comments

@moeyensj
Copy link
Owner

Either the documentation needs to be fixed or the returned array shape. The documentation suggests that the returned array is N observations by M filters, but instead the transpose is returned. The array is then transposed inside the fit function to get it to the correct shape.
@moeyensj moeyensj added the enhancement New feature or request label Jul 15, 2020
@moeyensj moeyensj self-assigned this Jul 15, 2020
@moeyensj moeyensj added the duplicate This issue or pull request already exists label Jul 15, 2020
@moeyensj
Copy link
Owner Author

Related and partially duplicate of #6.

@moeyensj moeyensj added bug Something isn't working documentation Improvements or additions to documentation and removed enhancement New feature or request labels Jul 15, 2020
@laithalfar
Copy link

So is it the documentation or the function that must be changed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@moeyensj moeyensj

Labels
bug Something isn't working documentation Improvements or additions to documentation duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@moeyensj @laithalfar