feat(runtime): pass all loader hooks to the fetch and script functions #3174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: aeda8cb The changes in this PR will be included in the next version bump. This PR includes changesets to release 25 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![squadronai[bot]](https://avatars.githubusercontent.com/in/901096?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary
The pull request introduces changes to the runtime and SDK modules to allow for the passing of all loader hooks to the fetch and script functions. This provides more flexibility and control over the remote loading process, enabling developers to customize the fetch and script creation behavior using the provided hooks.
The key changes include:
- Updating the
RemoteHandlerclass in the runtime module to accept aloaderHookparameter, which allows for passing all loader hooks to thefetchandscriptfunctions. - Modifying the
loadEntryScript,loadEntryDom, andloadEntryNodefunctions in the runtime utilities to accept aloaderHookparameter, enabling the passing of all loader hooks to thefetchandscriptfunctions. - Adding a
loaderHookparameter to thecreateScriptNodeandloadScriptNodefunctions in the SDK module, allowing for customization of the fetch and script creation behavior using the provided hooks. - Introducing a new
FetchHooktype in the SDK types, which represents a function that can be used to intercept and customize the fetch request made by the SDK.
These changes enhance the flexibility and extensibility of the runtime and SDK modules, enabling developers to better integrate remote loading functionality with their existing codebase.
File Summaries
| File | Summary |
|---|---|
| packages/runtime/src/remote/index.ts | The code changes introduce a new parameter to the loadEntry hook in the RemoteHandler class. The loaderHook parameter is now passed instead of the specific createScriptHook function, allowing for all loader hooks to be passed to the fetch and script functions. This change provides more flexibility and control over the remote loading process. |
| packages/runtime/src/utils/load.ts | The code changes introduce a new parameter loaderHook to the loadEntryScript, loadEntryDom, and loadEntryNode functions, which is used to pass all loader hooks to the fetch and script functions. This allows for more flexibility and customization in the loading process of remote entries. |
| packages/sdk/src/node.ts | The code changes introduce the ability to pass all loader hooks to the fetch and script functions in the runtime. This includes adding a new parameter loaderHook to the createScriptNode and loadScriptNode functions, which allows for customizing the fetch and script creation behavior using the provided hooks. |
| packages/sdk/src/types/hooks.ts | The code changes introduce a new FetchHook type that represents a function that can be used to intercept and customize the fetch request made by the SDK. This allows for greater flexibility and control over the network requests performed by the application. |
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Incremental Review
Comments posted: 7
Configuration
Squadron Mode: essential
Commits Reviewed
54bfd1cf730a842fd323d88d1b7c8ff72678f0ce...b6195d1a0789b42d98f6ad989773a4952be6bd7e
Files Reviewed
- packages/sdk/src/node.ts
- packages/sdk/src/types/hooks.ts
Files Ignored
These files were ignored due to the filter in the squadron.yaml file.
- .changeset/lucky-buckets-add.md
2heal1
approved these changes
Nov 5, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The pull request introduces changes to the runtime and SDK modules to allow for the passing of all loader hooks to the fetch and script functions. This provides more flexibility and control over the remote loading process, enabling developers to customize the fetch and script creation behavior using the provided hooks.
The key changes include:
RemoteHandlerclass in the runtime module to accept aloaderHookparameter, which allows for passing all loader hooks to thefetchandscriptfunctions.loadEntryScript,loadEntryDom, andloadEntryNodefunctions in the runtime utilities to accept aloaderHookparameter, enabling the passing of all loader hooks to thefetchandscriptfunctions.loaderHookparameter to thecreateScriptNodeandloadScriptNodefunctions in the SDK module, allowing for customization of the fetch and script creation behavior using the provided hooks.FetchHooktype in the SDK types, which represents a function that can be used to intercept and customize the fetch request made by the SDK.Related Issue
Types of changes
Checklist