Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Hot Reload for Ray Serve #29

Open
movchan74 opened this issue Dec 15, 2023 · 0 comments
Open

[FEATURE REQUEST] Hot Reload for Ray Serve #29

movchan74 opened this issue Dec 15, 2023 · 0 comments
Labels
enhancement New feature or request feature request High Priority High Priority

Comments

@movchan74
Copy link
Contributor

Feature Summary

Right now, if we make any changes to the code, the whole SDK needs to be restarted. This is not ideal because it takes a lot of time to restart the SDK especially if we have a lot of models and some of them take a long time to load (e.g. BLIP2). Ray isolates the models into deployments so it should be possible to reload only the deployment that was changed.

As a subtask of this issue, we also should be able to automatically reload the pipeline when it's changed.

Justification/Rationale

This will improve the developer experience by reducing the time it takes to test changes to the code.

Proposed Implementation (if any)

I've tried to do something like this already by watching the files for changes and reloading the deployment when a change is detected (basically killing it and Ray restarts it automatically). However, this doesn't work because the code is not reloaded, it still uses old code. I think this is because the code is loaded when the deployment is created and it's not possible to reload it just by restarting the deployment.

Another approach would be to serve build. I've tried to do this as well but it seems to have similar issue with reloading the code.

@ashwinnair14 ashwinnair14 added enhancement New feature or request High Priority High Priority labels Dec 18, 2023
@movchan74 movchan74 mentioned this issue Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature request High Priority High Priority
Projects
None yet
Development

No branches or pull requests

2 participants