Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation for ASR lang id #14

Open
HRashidi opened this issue Nov 15, 2023 · 0 comments
Open

Add validation for ASR lang id #14

HRashidi opened this issue Nov 15, 2023 · 0 comments
Labels
enhancement New feature or request wip Work In Progress

Comments

@HRashidi
Copy link
Contributor

HRashidi commented Nov 15, 2023 •
edited
Loading

Enhancement Description

  • Overview of the enhancement
    We need to validate the language id which user provide in the request so the

Advantages

  • Benefits of implementing this enhancement
    We can prevent submitting wrong lang id from the start instead of throwing error in the ray deployment when files are already downloaded and extracted.

Possible Implementation

  • Suggested methods for implementing the enhancement
    Using pydantic enums.
@HRashidi HRashidi added the enhancement New feature or request label Nov 15, 2023
@HRashidi HRashidi changed the title Add validation for ASR lang id [ENHANCEMENT] Add validation for ASR lang id Nov 15, 2023
@HRashidi HRashidi mentioned this issue Nov 15, 2023
Merged
@ashwinnair14 ashwinnair14 added the wip Work In Progress label Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request wip Work In Progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ashwinnair14 @HRashidi