Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring in Ord and PartialEq for Report #373

Closed
Tracked by #3428
, #3309
...
nick-mobilecoin opened this issue Jul 20, 2023 · 1 comment
Closed
Tracked by #3428
, #3309
...

Bring in Ord and PartialEq for Report #373

nick-mobilecoin opened this issue Jul 20, 2023 · 1 comment
Labels
needs-triage

Comments

@nick-mobilecoin
Copy link
Collaborator

nick-mobilecoin commented Jul 20, 2023 •
edited
Loading

IFF Report needs Ord and PartialEq we should bring in the logic from the MobileCoin repo as it was done to conform to a security audit.

https://github.com/mobilecoinfoundation/mobilecoin/blob/4dbbf0353078b94818358ef0ac10aa8d07394f0a/attest/core/src/report.rs#L80

At this time thinking this isn't needed, the only thing that was using Report with Ord was the NewEReportResponse which was removed in mobilecoinfoundation/mobilecoin#3454
This was referenced Jul 20, 2023
Open
Open
Closed
@nick-mobilecoin
Copy link
Collaborator Author

nick-mobilecoin commented Dec 4, 2023 •
edited
Loading

Closing as not needed, per

At this time thinking this isn't needed, the only thing that was using Report with Ord was the NewEReportResponse which was removed in mobilecoinfoundation/mobilecoin#3454

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nick-mobilecoin