Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feel confused about PDF evaluation of layered material #453

Open
ckf104 opened this issue Oct 25, 2024 · 0 comments
Open

Feel confused about PDF evaluation of layered material #453

ckf104 opened this issue Oct 25, 2024 · 0 comments

Comments

@ckf104
Copy link

ckf104 commented Oct 25, 2024

Equation 14.36 Gives mathematical expression of pdf value of layered material given $w_i$, $w_o$. But I can't understand why using brdf $p_r^+$ or btdf $p_t^+$ in equation, instead of using bsdf $p_s^+$.

And maybe it will be more clear to explain by code. Following code comes from PDF function of LayeredBxDF

        Float pdfSum = 0;
        if (SameHemisphere(wo, wi)) {
            auto reflFlag = BxDFReflTransFlags::Reflection;
            pdfSum += enteredTop ? nSamples * top.PDF(wo, wi, mode, reflFlag)
                                 : nSamples * bottom.PDF(wo, wi, mode, reflFlag);
        }

I feel confused why using BxDFReflTransFlags::Reflection as sampleFlags. Maybe BxDFReflTransFlags::All should be used? Since not only reflection, transmission will also be considered later.

I'd appreciate any help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant